Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 [backport release-0.3] Add and allow test image builds for more changes (#1926) #1928

Merged
merged 1 commit into from
May 29, 2024

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented May 29, 2024

Changes:

  • If any of the package.json files change, test the image builds. We want to make sure that changes to the engine or script blocks receive a full image build testing.

  • Update the npm version check to >=9.5.0. This will allow the test image build CI to check new builder images that also have npm major version updates.

Backport-of: #1926

…nges (konveyor#1926)

Changes:
  - If any of the `package.json` files change, test the image builds. We
    want to make sure that changes to the `engine` or `script` blocks
    receive a full image build testing.

  - Update the npm version check to `>=9.5.0`. This will allow the test
    image build CI to check new builder images that also have npm major
    version updates.

Backport-of: konveyor#1926
Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 requested review from ibolton336 and rszwajko May 29, 2024 15:49
@sjd78
Copy link
Member Author

sjd78 commented May 29, 2024

Note: The cherry-pick bot failed to create this backport. See https://github.com/konveyor/tackle2-ui/actions/runs/9289091416/job/25562122346#step:4:20.

Run BRANCH_NAME="cherry-pick-pr1926-release-0.3"
  BRANCH_NAME="cherry-pick-pr1926-release-0.3"
  git config --global user.email "[email protected]"
  git config --global user.name "Cherry Picker"
  git checkout -b ${BRANCH_NAME}
  git cherry-pick -s 66b06b067a017d1e4135dfacbe7d31c430853ae8
  git push origin ${BRANCH_NAME}
  gh pr create --base release-0.3 --fill
  shell: /usr/bin/bash -e {0}
  env:
    GH_TOKEN: ***
Switched to a new branch 'cherry-pick-pr1926-release-0.3'
Auto-merging .github/workflows/ci-image-build.yml
[cherry-pick-pr1926-release-0.3 d3655be4] :seedling: Add and allow test image builds for more changes (#1926)
 Author: Scott Dickerson <[email protected]>
 Date: Wed May 29 11:40:03 2024 -0400
 2 files changed, 2 insertions(+), 1 deletion(-)
To https://github.com/konveyor/tackle2-ui
 ! [remote rejected]   cherry-pick-pr1926-release-0.3 -> cherry-pick-pr1926-release-0.3 (refusing to allow a GitHub App to create or update workflow `.github/workflows/ci-image-build.yml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/konveyor/tackle2-ui'
Error: Process completed with exit code 1.

@sjd78 sjd78 merged commit 575ad2d into konveyor:release-0.3 May 29, 2024
9 checks passed
@sjd78 sjd78 deleted the backport_0.3_pr1926 branch July 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants