Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Unit test getLocalFilterDerivedState #1920

Merged
merged 1 commit into from
May 23, 2024

Conversation

rszwajko
Copy link
Collaborator

No description provided.

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko rszwajko requested review from ibolton336, scoonRH and sjd78 and removed request for scoonRH May 22, 2024 17:18
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.77%. Comparing base (b654645) to head (649f2ea).
Report is 141 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
+ Coverage   39.20%   41.77%   +2.57%     
==========================================
  Files         146      163      +17     
  Lines        4857     5266     +409     
  Branches     1164     1295     +131     
==========================================
+ Hits         1904     2200     +296     
- Misses       2939     3050     +111     
- Partials       14       16       +2     
Flag Coverage Δ
client 41.77% <ø> (+2.57%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(with the extreme minor nit-pick that I like a line of white-space between it() calls so my eyes can more easily pattern match the block -- but that is a Scott preference thing)

@rszwajko rszwajko merged commit a8f75fd into konveyor:main May 23, 2024
12 checks passed
@ibolton336
Copy link
Member

LGTM

@sjd78 sjd78 added this to the v0.5.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants