🐛 Add input text box filtering in new tag's select a tag category field #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpunwatk
changed the title
Signed-off-by: Karishma Punwatkar <[email protected]> modified: client/src/app/pages/controls/tags/components/tag-form.tsx
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
==========================================
+ Coverage 39.20% 42.13% +2.93%
==========================================
Files 146 163 +17
Lines 4857 5236 +379
Branches 1164 1274 +110
==========================================
+ Hits 1904 2206 +302
- Misses 2939 3014 +75
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kpunwatk
changed the title
|
Hi @ibolton336 @sjd78 Please review the PR, Thanks! |
ibolton336
approved these changes
May 21, 2024
sjd78
approved these changes
May 23, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RFE https://issues.redhat.com/browse/MTA-1248
User selecting a tag category from the drop-down should also be able to insert the input text. Instead of scrolling down and selecting from the long list would be very much convenient for user to enter the text and matching string gets filtered.