Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Test image build when build related files change #1907

Merged
merged 2 commits into from
May 14, 2024

Commits on May 10, 2024

  1. ✨ Test image build when build related files change

    If the workflow is run from a PR, and the PR includes
    a change to the `Dockerfile` or `package-lock.json`, then
    run image builds for all of our target platforms.
    
    The images are built but not pushed to any repository.
    
    We want to be reasonably sure that any major build file changes
    will not cause the image-build-and-push on PR merge workflow
    to break.  Doing the image build here should show up most
    problems much earlier.  For example, a npm version update
    in the build container could break github action `nofiles`
    or network access capabilities for the npm install.
    
    See konveyor#1742, konveyor#1746, and konveyor#1781 for some other examples of
    when this check could have caught issues before a PR
    merge.
    
    Supports: konveyor#1883
    
    Signed-off-by: Scott J Dickerson <[email protected]>
    sjd78 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    be46e09 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    655deda View commit details
    Browse the repository at this point in the history