Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use separate chip groups for tag categories #1903

Merged
merged 5 commits into from
May 23, 2024
Merged

🐛 Use separate chip groups for tag categories #1903

merged 5 commits into from
May 23, 2024

Commits on May 22, 2024

  1. Refactor MuliselectFilterControl 

    Key points:
1. drop ununsed feature - using dictionary type for selectedOptions
2. drop state that can be calculated:
  a) active item from focusedItemIndex
  b) selectedOptions from filters
3. centralize id calculations - use prefix based on category title

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko
    rszwajko committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3c108d5 View commit details
    Browse the repository at this point in the history

  2. Use dedicated chip groups for tag categories 

    Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko
    rszwajko committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9c51b13 View commit details
    Browse the repository at this point in the history

  3. Add label styling for tag group 

    Additional changes: fix problem with chip groups disappearing when other
filter type was chosen.

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko
    rszwajko committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2542d4c View commit details
    Browse the repository at this point in the history

  4. Implement review suggestions 

    Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko
    rszwajko committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a289e19 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' into emptyChip

    @rszwajko
    rszwajko authored May 23, 2024
    Configuration menu
    Copy the full SHA
    f42287e View commit details
    Browse the repository at this point in the history