Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add nightly runs to the ci-repo.yml workflow #1899

Merged
merged 2 commits into from
May 8, 2024

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented May 3, 2024

To better support ongoing green builds, add a nightly run on main from the repo level CI. The nightly run is embedded into the existing ci-repo.yml so the PR checks, merge/push to main, and nightly runs all use the same workflow.

This should also allow the CI repo's main README.md to have a full set of CI badges.

Note: The codecov actions will only be run when the workflow is run for a PR.

To better support ongoing green builds, add a nightly run
on main from the repo level CI.  The nightly run is
embedded into the existing `ci-repo.yml` so the PR checks,
merge/push to main, and nightly runs all use the same workflow.

This should also allow the CI repo's main README.md to
have a full set of CI badges.

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 requested review from ibolton336 and rszwajko May 3, 2024 18:20
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.24%. Comparing base (b654645) to head (5bb029c).
Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
+ Coverage   39.20%   41.24%   +2.04%     
==========================================
  Files         146      149       +3     
  Lines        4857     5004     +147     
  Branches     1164     1281     +117     
==========================================
+ Hits         1904     2064     +160     
+ Misses       2939     2829     -110     
- Partials       14      111      +97     
Flag Coverage Δ
client 41.24% <ø> (+2.04%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

sjd78 added a commit to sjd78/konveyor-ci that referenced this pull request May 6, 2024
Show the status badge for the nightly runs of the
UI workflow `ci-repo.yml`.  Until the workflow's
update is merged, and a scheduled run happens,
the status will be reported as "no status".

Related to: konveyor/tackle2-ui#1899

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 merged commit 802f366 into konveyor:main May 8, 2024
10 checks passed
@sjd78 sjd78 deleted the nightly_ci branch May 8, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants