Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Upgrade Axios #1870

Merged
merged 1 commit into from
Apr 24, 2024
Merged

👻 Upgrade Axios #1870

merged 1 commit into from
Apr 24, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Apr 19, 2024

@ibolton336 ibolton336 changed the title Your commit message 👻 Upgrade Axios Apr 19, 2024
@ibolton336 ibolton336 changed the title 👻 Upgrade Axios [wip] 👻 Upgrade Axios Apr 22, 2024
@ibolton336 ibolton336 marked this pull request as ready for review April 23, 2024 20:01
@ibolton336 ibolton336 changed the title [wip] 👻 Upgrade Axios 👻 Upgrade Axios Apr 23, 2024
@ibolton336 ibolton336 requested a review from sjd78 April 23, 2024 20:03
@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Apr 23, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test passed. 😄

Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need default handler that would silence the errors - sth similar to mock.onAny().reply(200, []).

client/src/app/api/rest.ts Outdated Show resolved Hide resolved
@rszwajko rszwajko self-requested a review April 24, 2024 18:45
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibolton336
I'm OK with fixing the logs in a follow-up

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Minor comments in a few places.

client/src/app/api/rest.ts Outdated Show resolved Hide resolved
Comment on lines +114 to +119
const jsonHeaders: RawAxiosRequestHeaders = {
Accept: "application/json",
};
const formHeaders: RawAxiosRequestHeaders = {
Accept: "multipart/form-data",
};
const fileHeaders: RawAxiosRequestHeaders = { Accept: "application/json" };
const yamlHeaders: RawAxiosRequestHeaders = {
Accept: "application/x-yaml",
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+100 on this change!

package.json Outdated Show resolved Hide resolved
- Remove axios-mock package

Signed-off-by: Ian Bolton <[email protected]>
@ibolton336 ibolton336 requested a review from sjd78 April 24, 2024 19:37
@ibolton336 ibolton336 merged commit 8715dbe into konveyor:main Apr 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants