-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 Upgrade Axios #1870
👻 Upgrade Axios #1870
Conversation
6d31869
to
eba3308
Compare
eba3308
to
1288932
Compare
eba36e2
to
a02aabe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke test passed. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need default handler that would silence the errors - sth similar to mock.onAny().reply(200, [])
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibolton336
I'm OK with fixing the logs in a follow-up
70f1c8a
to
744ed51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Minor comments in a few places.
const jsonHeaders: RawAxiosRequestHeaders = { | ||
Accept: "application/json", | ||
}; | ||
const formHeaders: RawAxiosRequestHeaders = { | ||
Accept: "multipart/form-data", | ||
}; | ||
const fileHeaders: RawAxiosRequestHeaders = { Accept: "application/json" }; | ||
const yamlHeaders: RawAxiosRequestHeaders = { | ||
Accept: "application/x-yaml", | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+100 on this change!
...t/src/app/pages/applications/components/application-form/__tests__/application-form.test.tsx
Show resolved
Hide resolved
client/src/app/pages/identities/components/identity-form/__tests__/identity-form.test.tsx
Show resolved
Hide resolved
- Remove axios-mock package Signed-off-by: Ian Bolton <[email protected]>
744ed51
to
acacdb8
Compare
Upgrade Axios
Resolves https://issues.redhat.com/browse/MTA-2326