Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Enable save on assessment change #1858

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Apr 18, 2024

The change is detected by comparing form values with initial values.
Properties checked:

  1. stakeholders
  2. stakeholder groups
  3. questions

Resolves: https://issues.redhat.com/browse/MTA-2655

@rszwajko rszwajko force-pushed the detectAssessmentChange branch 2 times, most recently from 32ba708 to a5f0f99 Compare April 19, 2024 16:28
@rszwajko rszwajko marked this pull request as ready for review April 19, 2024 16:32
@sjd78 sjd78 added this to the v0.5.0 milestone Apr 19, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one non-blocking nit-pick

The change is detected by comparing form values with initial values.
Properties checked:
1. stakeholders
2. stakeholder groups
3. questions

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants