🐛 MTA-1997 fix for column layout changing widths upon creation/deletion #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
align-columns
branch
3 times, most recently
from
798e4a4
to
7b85e5d
Compare
ibolton336
changed the title
ibolton336
force-pushed
the
align-columns
branch
from
c053dc7
to
35ab0f2
Compare
rszwajko
approved these changes
Apr 9, 2024
sjd78
approved these changes
Apr 12, 2024
| <Td | ||
| width={10} | ||
| {...getTdProps({ columnKey: "description" })} | ||
| <Tbody key={stakeholderGroups?.length}> |
There was a problem hiding this comment.
I know multiple Tbody tags are allowable, but with PF styling things could get wonky. Good idea to pull it out!
Signed-off-by: Ian Bolton <[email protected]>
ibolton336
force-pushed
the
align-columns
branch
from
02e8195
to
734d905
Compare
ibolton336
added
the
cherry-pick/release-0.3
ibolton336
added a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Apr 16, 2024
…on (konveyor#1807) Resolves https://issues.redhat.com/browse/MTA-1997 Match space allocation between column headers and rows to prevent layout shift when the first / last item is added / removed from the table. Before: https://github.com/konveyor/tackle2-ui/assets/11218376/e5564ea6-e78c-4fc0-92f2-dea496d6b88f After: https://github.com/konveyor/tackle2-ui/assets/11218376/7d12ddbd-c46a-4b06-970d-876fe2f90421 - Also addresses mishandling of TBody resulting in several Tbody elements rendered for each row in the table. Signed-off-by: Ian Bolton <[email protected]>
ibolton336
added a commit
that referenced
this pull request
Apr 16, 2024
…1853) …letion (#1807) Resolves https://issues.redhat.com/browse/MTA-1997 Match space allocation between column headers and rows to prevent layout shift when the first / last item is added / removed from the table. Before: https://github.com/konveyor/tackle2-ui/assets/11218376/e5564ea6-e78c-4fc0-92f2-dea496d6b88f After: https://github.com/konveyor/tackle2-ui/assets/11218376/7d12ddbd-c46a-4b06-970d-876fe2f90421 - Also addresses mishandling of TBody resulting in several Tbody elements rendered for each row in the table. <!-- ## PR Title Prefix Every **PR Title** should be prefixed with :text: to indicate its type. - Breaking change:⚠️ (`⚠️ `) - Non-breaking feature: ✨ (`✨`) - Patch fix: 🐛 (`🐛`) - Docs: 📖 (`📖`) - Infra/Tests/Other: 🌱 (`🌱`) - No release note: 👻 (`👻`) For example, a pull request containing breaking changes might look like `⚠️ My pull request contains breaking changes`. Since GitHub supports emoji aliases (ie. `👻`), there is no need to include the emoji directly in the PR title -- **please use the alias**. It used to be the case that projects using emojis for PR typing had to include the emoji directly because GitHub didn't render the alias. Given that `⚠️ ` is easy enough to read as text, easy to parse in release tooling, and rendered in GitHub well, we prefer to standardize on the alias. For more information, please see the Konveyor [Versioning Doc](https://github.com/konveyor/release-tools/blob/main/VERSIONING.md). --> Signed-off-by: Ian Bolton <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-1997
Match space allocation between column headers and rows to prevent layout shift when the first / last item is added / removed from the table.
Before:
Screen.Recording.2024-03-29.at.3.43.19.PM.mov
After:
Screen.Recording.2024-03-29.at.3.42.13.PM.mov