-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Reduce form fields in assessment wizard stakeholder page to a single dropdown #1799
Conversation
5ff0f34
to
0cff3f1
Compare
/hold for QE e2e test updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding grouping to Autocomplete
required massive changes. I feel we need to revisit the approach(some ideas in comments below). Alternatively we could break the component into parts and used them to build 2 specialized components i.e. GroupedAutocomplete and StandardAutocomplete.
e227f7a
to
4228e53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should make the Autocomplete grouped-by-default - without the need to toggle a special mode using a flag (and branch based on it). If no group
prop is provided (it's optional) then such option is put into "Ungrouped" category. If all options are there then we have the use case currently supported with isGrouped === false
.
Main advantages:
- no branches in the code and simpler code in general
- ability to mix grouped and non-grouped options (it's a legal use case)
488d071
to
15e8a9b
Compare
ad9858b
to
346f2bb
Compare
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
ea5aa4c
to
d815290
Compare
Signed-off-by: Ian Bolton <[email protected]>
d815290
to
bceb4f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
+ Coverage 39.20% 41.34% +2.13%
==========================================
Files 146 163 +17
Lines 4857 5266 +409
Branches 1164 1295 +131
==========================================
+ Hits 1904 2177 +273
- Misses 2939 3073 +134
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Resolves: #1709
Screen.Recording.2024-03-26.at.10.21.08.PM.mov