Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Reduce form fields in assessment wizard stakeholder page to a single dropdown #1799

Merged
merged 10 commits into from
May 21, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Mar 27, 2024

Resolves: #1709

Screen.Recording.2024-03-26.at.10.21.08.PM.mov

@ibolton336 ibolton336 marked this pull request as ready for review March 27, 2024 02:24
@ibolton336 ibolton336 force-pushed the assessment-wizard branch 2 times, most recently from 5ff0f34 to 0cff3f1 Compare March 27, 2024 02:32
@ibolton336 ibolton336 marked this pull request as draft March 27, 2024 20:06
@ibolton336
Copy link
Member Author

/hold for QE e2e test updates

@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Mar 28, 2024
@ibolton336 ibolton336 marked this pull request as ready for review March 28, 2024 19:31
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding grouping to Autocomplete required massive changes. I feel we need to revisit the approach(some ideas in comments below). Alternatively we could break the component into parts and used them to build 2 specialized components i.e. GroupedAutocomplete and StandardAutocomplete.

client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should make the Autocomplete grouped-by-default - without the need to toggle a special mode using a flag (and branch based on it). If no group prop is provided (it's optional) then such option is put into "Ungrouped" category. If all options are there then we have the use case currently supported with isGrouped === false.
Main advantages:

  1. no branches in the code and simpler code in general
  2. ability to mix grouped and non-grouped options (it's a legal use case)

client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
@ibolton336 ibolton336 closed this Apr 25, 2024
@ibolton336 ibolton336 reopened this Apr 25, 2024
@ibolton336 ibolton336 closed this Apr 25, 2024
@ibolton336 ibolton336 reopened this Apr 25, 2024
@ibolton336 ibolton336 closed this Apr 26, 2024
@ibolton336 ibolton336 reopened this Apr 26, 2024
@sjd78 sjd78 removed the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label May 3, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone May 3, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 38.13953% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 41.34%. Comparing base (b654645) to head (7c4beeb).
Report is 140 commits behind head on main.

Files Patch % Lines
...components/Autocomplete/useAutocompleteHandlers.ts 31.03% 60 Missing ⚠️
...pp/components/Autocomplete/GroupedAutocomplete.tsx 19.04% 34 Missing ⚠️
...t/src/app/components/Autocomplete/Autocomplete.tsx 51.16% 21 Missing ⚠️
...nt/src/app/components/Autocomplete/SearchInput.tsx 58.82% 7 Missing ⚠️
...mponents/HookFormPFFields/HookFormAutocomplete.tsx 50.00% 5 Missing ⚠️
client/src/app/components/LabelTooltip.tsx 62.50% 3 Missing ⚠️
...ient/src/app/components/Autocomplete/type-utils.ts 33.33% 2 Missing ⚠️
client/src/app/utils/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   39.20%   41.34%   +2.13%     
==========================================
  Files         146      163      +17     
  Lines        4857     5266     +409     
  Branches     1164     1295     +131     
==========================================
+ Hits         1904     2177     +273     
- Misses       2939     3073     +134     
- Partials       14       16       +2     
Flag Coverage Δ
client 41.34% <38.13%> (+2.13%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Assessment wizard - Skip
3 participants