✨ Add assessment/review status to archetype table

[rszwajko]

Review states:

1. Completed - a review exists
2. NotStarted

Assessment states:

1. Completed - all required assessments done (based on 'assessed' flag)
2. InProgress - some assessments done
3. NotStarted

Resolves: #1751

[rszwajko]

Assessment completed, review not started

Assessment in progress, review completed

[ibolton336]

Look good so far. Discarding review/assessment doesn't invalidate the archetypes query & results in stale data.

[rszwajko]

@ibolton336

Discarding review/assessment doesn't invalidate the archetypes query & results in stale data.

I've added the invalidation but the re-fetch is happening too quick. Even when manual refetch() is used then only 2nd or 3rd call returns updated value.

[sjd78]

Look good so far. Discarding review/assessment doesn't invalidate the archetypes query & results in stale data.

This is what application table does:

tackle2-ui/client/src/app/pages/applications/applications-table/applications-table.tsx

Lines 246 to 258 in 3e3d690

	const onDeleteReviewSuccess = (name: string) => {
	pushNotification({
	title: t("toastr.success.reviewDiscarded", {
	application: name,
	}),
	variant: "success",
	});
	queryClient.invalidateQueries([ApplicationsQueryKey]);
	};
	const { mutate: deleteReview } = useDeleteReviewMutation(
	onDeleteReviewSuccess
	);

tackle2-ui/client/src/app/pages/applications/applications-table/applications-table.tsx

Lines 291 to 306 in 3e3d690

	const discardReview = async (application: Application) => {
	try {
	if (application.review?.id) {
	await deleteReview({
	id: application.review.id,
	name: application.name,
	});
	}
	} catch (error) {
	console.error("Error while deleting review:", error);
	pushNotification({
	title: getAxiosErrorMessage(error as AxiosError),
	variant: "danger",
	});
	}
	};

I'm not a fan of the invalidation in the component's mutation onSuccess() handler, but it is what it is.

[sjd78]

LGTM

Tested and the assessment and review columns seem to reset immediately after the delete/discard is complete. Looks like the query invalidations are working correctly now.

Stale data issue tests to be fixed.

[rszwajko]

@sjd78 removed unnecessary async in the newest force push

[sjd78]

LGTM and no more nit-picks! :-)

[ibolton336]

LGTM!

[aufi]

LGTM