🐛 Optimize assessment fetching #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
added
the
cherry-pick/release-0.3
Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
dymurray
approved these changes
Feb 28, 2024
sjd78
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
visack is ok
Considering how more things are being fetched and processed in aggregate, it may be time to reconsider how the query hooks are structured. There is a lot going on here and it is not unit/integration testable. It's to keep in mind and work on in the near future as things will not get less complicated as we go.
|
|
||
| if (fetchError) { | ||
| return <EmptyTextMessage message={t("terms.notAvailable")} />; | ||
| } | ||
|
|
||
| if (isFetching || isFetchingAssessmentsById) { | ||
| if (isFetching || isFetching) { |
There was a problem hiding this comment.
Suggested change
| if (isFetching || isFetching) { | |
| if (isFetching) { |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Resolves https://issues.redhat.com/browse/MTA-2296 Resolves https://issues.redhat.com/browse/MTA-1973 --------- Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
ibolton336
added a commit
that referenced
this pull request
Feb 28, 2024
Resolves https://issues.redhat.com/browse/MTA-2296 Resolves https://issues.redhat.com/browse/MTA-1973 --------- Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-2296
Resolves https://issues.redhat.com/browse/MTA-1973