🐛 Load filter values for multiselect before input #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onveyor#1702) Resolves https://issues.redhat.com/browse/MTA-2004 <img width="1197" alt="Screenshot 2024-02-27 at 9 59 25 AM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/720d137a-098b-4736-ba1c-b0905073c144"> --------- Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
ibolton336
force-pushed
the
filter-bug
branch
from
1699ba3
to
e6e55eb
Compare
ibolton336
added
the
cherry-pick/release-0.3
sjd78
reviewed
Feb 28, 2024
Comment on lines
+52
to
+57
| React.useEffect(() => { | ||
| setSelectOptions( | ||
| Array.isArray(category.selectOptions) ? category.selectOptions : [] | ||
| ); | ||
| }, [category.selectOptions]); | ||
|
|
There was a problem hiding this comment.
What happen if you just drop saving the "selectOptions" as state? I don't see anywhere in the component's code where the options are better off being held in state instead of just:
const selectOptions = Array.isArray(category.selectOptions) ? category.selectOptions : [];Worst case you wrap it in a useMemo, but that wouldn't really even justify the extra cognitive complexity when a string assignment at each render should work just fine.
There was a problem hiding this comment.
Need to be able to update the options when the text input changes on line 256.
There was a problem hiding this comment.
Ok but still feels awkward. A bigger refactor to rearrange how the component handles input text filtering of the selectOptions could make the data flow easier to track.
dymurray
approved these changes
Feb 28, 2024
sjd78
approved these changes
Feb 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Resolves https://issues.redhat.com/browse/MTA-2322 - Need to load the select options into the dropdown state in cases where category.selectOptions is async --------- Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
ibolton336
added a commit
that referenced
this pull request
Feb 29, 2024
Resolves https://issues.redhat.com/browse/MTA-2322 - Need to load the select options into the dropdown state in cases where category.selectOptions is async --------- Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-2322