Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Extend notification delay & fix broken delay customization #1690

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Feb 16, 2024

https://issues.redhat.com/browse/MTA-2260

  • Previously, the notification delay timeout was being overridden by the timeout set on the alert component itself. This fixes this accidental override.
  • Lengthens timeout for notification clear globally to 8 seconds.

@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Feb 21, 2024
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibolton336 ibolton336 merged commit 388a442 into konveyor:main Feb 21, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
https://issues.redhat.com/browse/MTA-2260
- Previously, the notification delay timeout was being overridden by the
timeout set on the alert component itself. This fixes this accidental
override.
- Lengthens timeout for notification clear globally to 8 seconds.

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
ibolton336 added a commit that referenced this pull request Feb 21, 2024
…1695)

https://issues.redhat.com/browse/MTA-2260
- Previously, the notification delay timeout was being overridden by the
timeout set on the alert component itself. This fixes this accidental
override.
- Lengthens timeout for notification clear globally to 8 seconds.

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
@ibolton336 ibolton336 deleted the mta-2260 branch February 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants