🐛 Adding tooltip to PencilAltIcon #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
requested changes
Feb 15, 2024
| setSaveApplicationModalState(application) | ||
| } | ||
| /> | ||
| <Tooltip content="Edit"> |
There was a problem hiding this comment.
Needs internationalization but overall looking good. checkout the other usages of useTranslation amongst the app.
Will need const {t} = useTranslation() and will need to add an entry to the translations.json file for the english language subdirectory.
Signed-off-by: Maayan Hadasi <[email protected]>
Signed-off-by: Maayan Hadasi <[email protected]>
mguetta1
force-pushed
the
fix-mta-1468
branch
from
5f043b2
to
091457e
Compare
Merged
ibolton336
pushed a commit
that referenced
this pull request
Feb 29, 2024
Cherry-pick #1688 --------- Signed-off-by: Maayan Hadasi <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-1468