Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add tooltip for unlink jira ticket #1643

Merged
merged 1 commit into from
Dec 19, 2023
Merged

🐛 Add tooltip for unlink jira ticket #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client/public/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@
"taskInProgressForTags": "A new analysis is in-progress. Tags may be updated upon completion.",
"toTagApplication": "Either no tags exist yet or you may not have permission to view any. If you have permission, try creating a new custom tag.",
"unsavedChanges": "Are you sure you want to close the assessment? Any unsaved changes will be lost.",
"noAnswers": "Are you sure you want to close the assessment? There are no answers to save."
"noAnswers": "Are you sure you want to close the assessment? There are no answers to save.",
"unlinkTicket": "Unlink from Jira"
},
"proposedActions": {
"refactor": "Refactor",
Expand Down Expand Up @@ -308,7 +309,7 @@
"date": "Date",
"decision": "Decision",
"dependencies": "Dependencies",
"dependentQuestion": "Dependent question",
"dependentQuestion": "Conditional question",
"description": "Description",
"details": "Details",
"displayName": "Display name",
Expand Down
17 changes: 12 additions & 5 deletions ...app/pages/applications/components/application-detail-drawer/application-detail-fields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
Grid,
GridItem,
Spinner,
Tooltip,
} from "@patternfly/react-core";
import { Application } from "@app/api/models";
import spacing from "@patternfly/react-styles/css/utilities/Spacing/spacing";
Expand Down Expand Up @@ -187,11 +188,17 @@ export const ApplicationDetailFields: React.FC<{
isLoading ? (
<Spinner role="status" size="sm" />
) : (
<Button
variant="link"
icon={<UnlinkIcon />}
onClick={() => deleteTicket(matchingTicket.id)}
/>
<Tooltip
content={t("message.unlinkTicket")}
position="top"
entryDelay={1000}
>
<Button
variant="link"
icon={<UnlinkIcon />}
onClick={() => deleteTicket(matchingTicket.id)}
/>
</Tooltip>
)
) : null}
</Text>
Expand Down
17 changes: 12 additions & 5 deletions client/src/app/pages/migration-waves/components/wave-status-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
Toolbar,
ToolbarContent,
ToolbarItem,
Tooltip,
} from "@patternfly/react-core";
import { Table, Tbody, Td, Th, Thead, Tr } from "@patternfly/react-table";
import alignment from "@patternfly/react-styles/css/utilities/Alignment/alignment";
Expand Down Expand Up @@ -165,11 +166,17 @@ export const WaveStatusTable: React.FC<IWaveStatusTableProps> = ({
</Td>
<Td className={alignment.textAlignRight}>
{ticket?.id && (
<Button
variant="link"
icon={<UnlinkIcon />}
onClick={() => deleteTicket(ticket.id)}
/>
<Tooltip
content={t("message.unlinkTicket")}
position="top"
entryDelay={1000}
>
<Button
variant="link"
icon={<UnlinkIcon />}
onClick={() => deleteTicket(ticket.id)}
/>
</Tooltip>
)}
<Button
type="button"
Expand Down
Loading