Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix pagination effects - for client tables, use filteredItems instead of items length for totalItemCount #1625

Merged
merged 2 commits into from
Dec 15, 2023
Merged

🐛 Fix pagination effects - for client tables, use filteredItems instead of items length for totalItemCount #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b93bf2f
Fix pagination effects - for client tables, use filteredItems instead…
mturley Dec 14, 2023
d8ee7ce
Merge branch 'main' into fix-total-item-count
ibolton336 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/app/hooks/table-controls/getLocalTableControlDerivedState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const getLocalTableControlDerivedState = <
items: sortedItems,
});
return {
totalItemCount: items.length,
totalItemCount: filteredItems.length,
currentPageItems: isPaginationEnabled ? currentPageItems : sortedItems,
};
};
2 changes: 1 addition & 1 deletion client/src/app/hooks/table-controls/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export type ITableControlDerivedState<TItem> = {
*/
currentPageItems: TItem[];
/**
* The total number of items in the entire un-filtered, un-paginated table (the size of the entire API collection being tabulated).
* The total number of items after filtering but before pagination.
*/
totalItemCount: number;
};
Expand Down
Loading