🐛 Update archetype rbac scopes #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ibolton336 <[email protected]>
sjd78
reviewed
Dec 14, 2023
Comment on lines
+383
to
+391
| ...(archetypeWriteAccess | ||
| ? [ | ||
| { | ||
| title: t("actions.duplicate"), | ||
| onClick: () => | ||
| setArchetypeToDuplicate(archetype), | ||
| }, | ||
| ] | ||
| : []), |
There was a problem hiding this comment.
The alternate form would be to drop undefieneds and then .filter(Boolean) at the end...
[
archetypeWriteAccess && {
title: ...
...
},
assessmentWriteAccess && { ... },
...
].filter(Boolean)
Comment on lines
+282
to
+286
| const token = keycloak.tokenParsed; | ||
| const userScopes: string[] = token?.scope.split(" ") || [], | ||
| archetypeWriteAccess = checkAccess(userScopes, archetypesWriteScopes), | ||
| assessmentWriteAccess = checkAccess(userScopes, assessmentWriteScopes), | ||
| reviewsWriteAccess = checkAccess(userScopes, reviewsWriteScopes); |
There was a problem hiding this comment.
I know this is what we have to work with right now, but it pains me just a bit.
sjd78
approved these changes
Dec 14, 2023
This was referenced Dec 16, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTA-1893