Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add risk description when available #1617

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

ibolton336
Copy link
Member

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b654645) 39.20% compared to head (8f23cff) 39.13%.
Report is 1 commits behind head on main.

❗ Current head 8f23cff differs from pull request most recent head 03821d7. Consider uploading reports for the commit 03821d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
- Coverage   39.20%   39.13%   -0.07%     
==========================================
  Files         146      146              
  Lines        4857     4850       -7     
  Branches     1164     1205      +41     
==========================================
- Hits         1904     1898       -6     
+ Misses       2939     2850      -89     
- Partials       14      102      +88     
Flag Coverage Δ
client 39.13% <ø> (-0.07%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that when "all questionnaires" is selected no riskDescription is given, LGTM

Ah yes, good to go:

const questionnaire = isAllQuestionnairesSelected
? null
: questionnairesById[selectedQuestionnaireId];

<ApplicationLandscape
questionnaire={questionnaire}
assessmentRefs={assessmentRefs}
/>

<Donut
isAssessment={false}
id="landscape-donut-red"
value={landscapeData.red}
total={landscapeData.applicationsCount}
color={RISK_LIST.red.hexColor}
riskLabel={
<Link to={getRisksUrl(["red"])}>{t("terms.highRisk")}</Link>
}
riskTitle={t("terms.highRisk")}
riskDescription={questionnaire?.riskMessages?.red ?? ""}
/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants