-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add risk description when available #1617
Conversation
Signed-off-by: ibolton336 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
- Coverage 39.20% 39.13% -0.07%
==========================================
Files 146 146
Lines 4857 4850 -7
Branches 1164 1205 +41
==========================================
- Hits 1904 1898 -6
+ Misses 2939 2850 -89
- Partials 14 102 +88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that when "all questionnaires" is selected no riskDescription
is given, LGTM
Ah yes, good to go:
tackle2-ui/client/src/app/pages/reports/reports.tsx
Lines 120 to 122 in 1dd15d7
const questionnaire = isAllQuestionnairesSelected | |
? null | |
: questionnairesById[selectedQuestionnaireId]; |
tackle2-ui/client/src/app/pages/reports/reports.tsx
Lines 209 to 212 in 1dd15d7
<ApplicationLandscape | |
questionnaire={questionnaire} | |
assessmentRefs={assessmentRefs} | |
/> |
tackle2-ui/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx
Lines 142 to 153 in 1dd15d7
<Donut | |
isAssessment={false} | |
id="landscape-donut-red" | |
value={landscapeData.red} | |
total={landscapeData.applicationsCount} | |
color={RISK_LIST.red.hexColor} | |
riskLabel={ | |
<Link to={getRisksUrl(["red"])}>{t("terms.highRisk")}</Link> | |
} | |
riskTitle={t("terms.highRisk")} | |
riskDescription={questionnaire?.riskMessages?.red ?? ""} | |
/> |
Resolves https://issues.redhat.com/browse/MTA-1868