Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Only load keycloak when AUTH_REQUIRED is "true" #1616

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Dec 13, 2023

Only add the actual AuthEnabledKeycloakProvider keycloak handler if the AUTH_REQUIRED environment variable is set "true".

Only add the actual `AuthEnabledKeycloakProvider` keycloak handler
if the `AUTH_REQUIRED` environment variable is set `"true"`.

Signed-off-by: Scott J Dickerson <[email protected]>
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VISACK

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eea7835) 39.13% compared to head (9795108) 39.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1616   +/-   ##
=======================================
  Coverage   39.13%   39.13%           
=======================================
  Files         146      146           
  Lines        4850     4850           
  Branches     1205     1205           
=======================================
  Hits         1898     1898           
  Misses       2850     2850           
  Partials      102      102           
Flag Coverage Δ
client 39.13% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will merge when CI finishes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants