-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix session expiry when refresh tokens are disabled #1614
Conversation
Signed-off-by: ibolton336 <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
- Coverage 39.24% 39.14% -0.11%
==========================================
Files 146 146
Lines 4834 4849 +15
Branches 1201 1205 +4
==========================================
+ Hits 1897 1898 +1
- Misses 2836 2849 +13
- Partials 101 102 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works to kick user back to login if the token cannot be refreshed.
In dev mode, there is a flash of an error screen before forwarding the user to the login screen. Hopefully that doesn't show when the app is running a prod build.
Code looks ok. I know ReactKeycloakProvider
and keycloak-js
are both deprecated. Refactoring those out should be on the tech-debt list.
@ibolton336 UI tests are red on this PR, is it possible this change broke them? I can't find an earlier PR with these failures |
)" This reverts commit eea7835.
…nveyor#1614)" This reverts commit eea7835. Signed-off-by: Fabian von Feilitzsch <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-1255