Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix session expiry when refresh tokens are disabled #1614

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Dec 12, 2023

Resolves https://issues.redhat.com/browse/MTA-1255

  • Since we no longer have to support windup reports in a new tab, this code can be cleaned up to use keycloaks internal session management

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (0f42c7e) 39.24% compared to head (9811757) 39.14%.

❗ Current head 9811757 differs from pull request most recent head a424810. Consider uploading reports for the commit a424810 to get more accurate results

Files Patch % Lines
client/src/app/axios-config/apiInit.ts 10.52% 15 Missing and 2 partials ⚠️
client/src/app/layout/HeaderApp/SSOMenu.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   39.24%   39.14%   -0.11%     
==========================================
  Files         146      146              
  Lines        4834     4849      +15     
  Branches     1201     1205       +4     
==========================================
+ Hits         1897     1898       +1     
- Misses       2836     2849      +13     
- Partials      101      102       +1     
Flag Coverage Δ
client 39.14% <9.52%> (-0.11%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works to kick user back to login if the token cannot be refreshed.

In dev mode, there is a flash of an error screen before forwarding the user to the login screen. Hopefully that doesn't show when the app is running a prod build.

Code looks ok. I know ReactKeycloakProvider and keycloak-js are both deprecated. Refactoring those out should be on the tech-debt list.

@ibolton336 ibolton336 merged commit eea7835 into konveyor:main Dec 13, 2023
4 checks passed
@fabianvf
Copy link
Contributor

@ibolton336 UI tests are red on this PR, is it possible this change broke them? I can't find an earlier PR with these failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants