Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix alignment on actions screen #1605

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Dec 11, 2023

  • Address issues with css alignment on assessment actions page

Before:
Screenshot 2023-12-11 at 10 47 34 AM

After:
Screenshot 2023-12-11 at 10 49 42 AM

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca600a3) 39.27% compared to head (7308556) 39.27%.
Report is 4 commits behind head on main.

❗ Current head 7308556 differs from pull request most recent head 229519c. Consider uploading reports for the commit 229519c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   39.27%   39.27%           
=======================================
  Files         146      146           
  Lines        4827     4827           
  Branches     1152     1197   +45     
=======================================
  Hits         1896     1896           
+ Misses       2917     2830   -87     
- Partials       14      101   +87     
Flag Coverage Δ
client 39.27% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 merged commit 21b7afd into konveyor:main Dec 11, 2023
4 checks passed
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I found that having a Button in a TD on any TR that is not inline makes the spacing weird. Marking the button <Button isInline ...>...</Button> seems to take care of the problems most of the time.

@ibolton336
Copy link
Member Author

FWIW, I found that having a Button in a TD on any TR that is not inline makes the spacing weird. Marking the button <Button isInline ...>...</Button> seems to take care of the problems most of the time.

Looks like that does partially fix the issue, but still seeing some style inconsistency with long questionnaire names.

Removing style changes to center the row content vertically & just use isInline for the buttons:

Screenshot 2023-12-11 at 1 17 49 PM

VS

Screenshot 2023-12-11 at 1 19 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants