Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Refactor WithUiId handling to use hook useWithUiId() #1555

Merged
merged 2 commits into from
Dec 14, 2023
Merged

🌱 Refactor WithUiId handling to use hook useWithUiId() #1555

merged 2 commits into from
Dec 14, 2023

Commits on Dec 14, 2023

  1. Refactor WithUiId handling to use hook useWithUiId() 

    Following up on konveyor#1554, create hook `useWithUiId()` to handle injecting
UI id to objects.  Any object `T` going will to the hook will come out
as a `WithUiId<T>` object.

Tables using the UI id have been adjusted to use the Constant
`UI_UNIQUE_ID` as the `WithUiId<T>` table data `idProperty`.

All uses of `WithUiId<T>` are now handled the same way.

Signed-off-by: Scott J Dickerson <[email protected]>
    @sjd78
    sjd78 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    2540075 View commit details
    Browse the repository at this point in the history

  2. Fix review comments 

      - Doc language
  - Remove custom query hook return type interfaces in favor of
    using TS type inference

Signed-off-by: Scott J Dickerson <[email protected]>
    @sjd78
    sjd78 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    92d4864 View commit details
    Browse the repository at this point in the history