Skip to content

Commit

Permalink
🌱 Setup CI workflow to use same container as Dockerfile (#1804) (#1823)
Browse files Browse the repository at this point in the history
Lookup the "FROM .* as builder" image from the project's Dockerfile, and
use that image to run the CI unit-test job.

This will ensure the unit-test job is using the same container image
that the image builds will be using. A problem with the container should
show up quickly in the unit-testing.

Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
  • Loading branch information
konveyor-ci-bot[bot] authored Apr 5, 2024
1 parent 8896fb4 commit c7776c5
Showing 1 changed file with 22 additions and 13 deletions.
35 changes: 22 additions & 13 deletions .github/workflows/ci-repo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,40 @@ on:
- "main"
- "release-*"

env:
# Note: This should match the node version(s) used in the base Dockerfile
node-version: "18"

jobs:
unit-test-lookup-image:
runs-on: ubuntu-latest
outputs:
builder-image: ${{ steps.grepBuilder.outputs.builder }}
steps:
- uses: actions/checkout@v4
- name: Lookup builder image from the project's Dockerfile
id: grepBuilder
run: |
builder=$(grep 'as builder' Dockerfile | sed -e 's/^FROM \(.*\) as builder$/\1/')
echo "Builder image: \`$builder\`" >> "$GITHUB_STEP_SUMMARY"
echo "builder=$builder" >> "$GITHUB_OUTPUT"
unit-test:
runs-on: ubuntu-latest
needs: unit-test-lookup-image

# Use the same container as the Dockerfile's "FROM * as builder"
container: ${{ needs.unit-test-lookup-image.outputs.builder-image }}

steps:
- uses: actions/checkout@v4

- name: Use Node.js (version "${{ env.node-version }}")
uses: actions/setup-node@v4
with:
node-version: ${{ env.node-version }}
cache: "npm"

- name: Force install npm@9 to match Dockerfile build container ubi9/nodejs-18:1-88
run: npm install -g npm@9
# TODO: Setup a cache for npm so it could install faster
# follow actions/setup-node@v4 techniques

- name: Verify package-lock.json
run: ./scripts/verify_lock.mjs

- name: Install
run: npm clean-install --ignore-scripts
run: |
npm version
npm clean-install --ignore-scripts
- name: Lint sources
run: npm run lint
Expand Down

0 comments on commit c7776c5

Please sign in to comment.