Skip to content

Commit

Permalink
🐛 Split the reports landscape unknown/unassessed chart (#2052) (#2054)
Browse files Browse the repository at this point in the history
Resolves: https://issues.redhat.com/browse/MTA-2678

On the reports page, split the combine Unknown / Unassessed landscape
chart into separate charts.

Unknown and unassessed are two different risk states.

Backport-of: #2052
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
  • Loading branch information
konveyor-ci-bot[bot] authored Aug 13, 2024
1 parent 0e004ea commit b7af71b
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 6 deletions.
1 change: 0 additions & 1 deletion client/public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,6 @@
"ticket": "Ticket",
"trivialButMigratable": "Trivial but migratable",
"type": "Type",
"unassessedOrUnknown": "Unassessed or unknown",
"unassessed": "Unassessed",
"unassigned": "Not yet assigned",
"unknown": "Unknown",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,29 @@ export const ApplicationLandscape: React.FC<IApplicationLandscapeProps> = ({
<FlexItem>
<Donut
isAssessment={false}
id="landscape-donut-unassessed"
value={landscapeData.unassessed + landscapeData.unknown}
id="landscape-donut-unknown"
value={landscapeData.unknown}
total={landscapeData.applicationsCount}
color={RISK_LIST.unknown.hexColor}
riskLabel={
<Link to={getRisksUrl(["unknown"])}>
{`${t("terms.unassessed")}/${t("terms.unknown")}`}
<Link to={getRisksUrl(["unknown"])}>{t("terms.unknown")}</Link>
}
riskTitle={t("terms.unknown")}
/>
</FlexItem>
<FlexItem>
<Donut
isAssessment={false}
id="landscape-donut-unassessed"
value={landscapeData.unassessed}
total={landscapeData.applicationsCount}
color={RISK_LIST.unassessed.hexColor}
riskLabel={
<Link to={getRisksUrl(["unassessed"])}>
{t("terms.unassessed")}
</Link>
}
riskTitle={t("terms.unassessedOrUnknown")}
riskTitle={t("terms.unassessed")}
/>
</FlexItem>
</Flex>
Expand Down

0 comments on commit b7af71b

Please sign in to comment.