👻 Refactor remaining legacy tables (#1877)

Closes #1283 --------- Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Radoslaw Szwajkowski <[email protected]>
konveyor · Apr 25, 2024 · a6e9afb · a6e9afb
1 parent 312b8b8
commit a6e9afb
Show file tree

Hide file tree

Showing 14 changed files with 587 additions and 856 deletions.
diff --git a/client/public/locales/en/translation.json b/client/public/locales/en/translation.json
@@ -450,6 +450,7 @@
     "teamMember": "team member",
     "ticket": "Ticket",
     "trivialButMigratable": "Trivial but migratable",
+    "type": "Type",
     "unassessedOrUnknown": "Unassessed or unknown",
     "unassessed": "Unassessed",
     "unassigned": "Not yet assigned",

diff --git a/client/src/app/components/AppTableActionButtons.tsx b/client/src/app/components/AppTableActionButtons.tsx
@@ -1,6 +1,6 @@
 import React from "react";
 import { useTranslation } from "react-i18next";
-import { Button } from "@patternfly/react-core";
+import { Button, Flex, FlexItem } from "@patternfly/react-core";
 import { applicationsWriteScopes, RBAC, RBAC_TYPE } from "@app/rbac";
 import { ConditionalTooltip } from "./ConditionalTooltip";
 import { Td } from "@patternfly/react-table";
@@ -26,30 +26,39 @@ export const AppTableActionButtons: React.FC<AppTableActionButtonsProps> = ({
       rbacType={RBAC_TYPE.Scope}
     >
       <Td isActionCell>
-        <Button
-          id="edit-button"
-          aria-label="edit"
-          variant="secondary"
-          onClick={onEdit}
+        <Flex
+          direction={{ default: "row" }}
+          flexWrap={{ default: "nowrap" }}
+          style={{ minWidth: "100%" }}
         >
-          {t("actions.edit")}
-        </Button>
-      </Td>
-      <Td isActionCell>
-        <ConditionalTooltip
-          isTooltipEnabled={isDeleteEnabled}
-          content={tooltipMessage}
-        >
-          <Button
-            id="delete-button"
-            aria-label="delete"
-            variant="link"
-            onClick={onDelete}
-            isAriaDisabled={isDeleteEnabled}
-          >
-            {t("actions.delete")}
-          </Button>
-        </ConditionalTooltip>
+          <FlexItem spacer={{ default: "spacerSm" }} />
+          <FlexItem spacer={{ default: "spacerSm" }}>
+            <Button
+              id="edit-button"
+              aria-label="edit"
+              variant="secondary"
+              onClick={onEdit}
+            >
+              {t("actions.edit")}
+            </Button>
+          </FlexItem>
+          <FlexItem spacer={{ default: "spacerSm" }}>
+            <ConditionalTooltip
+              isTooltipEnabled={isDeleteEnabled}
+              content={tooltipMessage}
+            >
+              <Button
+                id="delete-button"
+                aria-label="delete"
+                variant="link"
+                onClick={onDelete}
+                isAriaDisabled={isDeleteEnabled}
+              >
+                {t("actions.delete")}
+              </Button>
+            </ConditionalTooltip>
+          </FlexItem>
+        </Flex>
       </Td>
     </RBAC>
   );

diff --git a/client/src/app/components/AppTableWithControls.tsx b/client/src/app/components/AppTableWithControls.tsx