🐛 Fix application table isTaskCancellable

Application analysis tasks should be cancellable when the task in NOT in a terminal state. Use the `TaskStates.Terminal` collection for the check so all current terminal states are considered. Resolves: #1993 Resolves: https://issues.redhat.com/browse/MTA-3219 Signed-off-by: Scott J Dickerson <[email protected]>
konveyor · Jul 23, 2024 · 88296b0 · 88296b0
1 parent 0ba6691
commit 88296b0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/client/src/app/pages/applications/applications-table/applications-table.tsx b/client/src/app/pages/applications/applications-table/applications-table.tsx
@@ -212,7 +212,7 @@ export const ApplicationsTable: React.FC = () => {
 
   const isTaskCancellable = (application: DecoratedApplication) => {
     const task = application.tasks.currentAnalyzer;
-    return task?.state && !["Succeeded", "Failed"].includes(task.state);
+    return !TaskStates.Terminal.includes(task?.state ?? "");
   };
 
   // TODO: Review the refetchInterval calculation for the application list
@@ -979,16 +979,16 @@ export const ApplicationsTable: React.FC = () => {
                             title: t("actions.assess"),
                             onClick: () => assessSelectedApp(application),
                           },
-                          reviewsWriteAccess && {
-                            title: t("actions.review"),
-                            onClick: () => reviewSelectedApp(application),
-                          },
                           assessmentWriteAccess &&
                             (application.assessments?.length ?? 0) > 0 && {
                               title: t("actions.discardAssessment"),
                               onClick: () =>
                                 setAssessmentToDiscard(application),
                             },
+                          reviewsWriteAccess && {
+                            title: t("actions.review"),
+                            onClick: () => reviewSelectedApp(application),
+                          },
                           reviewsWriteAccess &&
                             application?.review && {
                               title: t("actions.discardReview"),