🐛 Trim unwanted questionnaire fields on export (#1584)

Resolves: https://issues.redhat.com/browse/MTA-1721 Signed-off-by: ibolton336 <[email protected]>
konveyor · Dec 4, 2023 · 4a90493 · 4a90493
1 parent 293a1d0
commit 4a90493
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 10 deletions.
diff --git a/client/src/app/api/models.ts b/client/src/app/api/models.ts
@@ -645,19 +645,26 @@ export type HubFile = {
   path: string;
 };
 
+export interface LooseQuestionnaire {
+  [key: string]: any;
+}
+
 export interface Questionnaire {
   id: number;
   name: string;
   description: string;
   revision: number;
   questions: number;
   rating: string;
-  createTime: string;
   required: boolean;
-  builtin?: boolean;
   sections: Section[];
   thresholds: Thresholds;
   riskMessages: RiskMessages;
+  builtin?: boolean;
+  createTime?: string;
+  createUser?: string;
+  updateTime?: string;
+  updateUser?: string;
 }
 
 export interface RiskMessages {

diff --git a/...sessment-management/assessment-settings/components/export-questionnaire-dropdown-item.tsx b/...sessment-management/assessment-settings/components/export-questionnaire-dropdown-item.tsx
@@ -10,11 +10,7 @@ export const ExportQuestionnaireDropdownItem: React.FC<
   IExportQuestionnaireDropdownItemProps
 > = ({ id }) => {
   const { t } = useTranslation();
-  const {
-    mutate: downloadFile,
-    isLoading,
-    isError,
-  } = useDownloadQuestionnaire();
+  const { mutate: downloadFile } = useDownloadQuestionnaire();
 
   const handleDownload = () => {
     downloadFile(id);

diff --git a/client/src/app/queries/questionnaires.ts b/client/src/app/queries/questionnaires.ts
@@ -1,5 +1,6 @@
 import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
 import axios, { AxiosError } from "axios";
+import yaml from "js-yaml";
 
 import {
   QUESTIONNAIRES,
@@ -9,7 +10,7 @@ import {
   getQuestionnaires,
   updateQuestionnaire,
 } from "@app/api/rest";
-import { Questionnaire } from "@app/api/models";
+import { LooseQuestionnaire, Questionnaire } from "@app/api/models";
 import saveAs from "file-saver";
 
 export const QuestionnairesQueryKey = "questionnaires";
@@ -121,7 +122,7 @@ export const downloadQuestionnaire = async (
 
   try {
     const response = await axios.get(url, {
-      responseType: "blob",
+      responseType: "text",
       headers: {
         Accept: "application/x-yaml",
       },
@@ -131,13 +132,24 @@ export const downloadQuestionnaire = async (
       throw new Error("Network response was not ok when downloading file.");
     }
 
-    const blob = new Blob([response.data]);
+    const yamlData = yaml.load(response.data) as LooseQuestionnaire;
+
+    delete yamlData.createUser;
+    delete yamlData.updateUser;
+    delete yamlData.createTime;
+    delete yamlData.id;
+
+    const newYamlData = yaml.dump(yamlData);
+
+    const blob = new Blob([newYamlData], { type: "application/x-yaml" });
+
     saveAs(blob, `questionnaire-${id}.yaml`);
   } catch (error) {
     console.error("There was an error downloading the file:", error);
     throw error;
   }
 };
+
 export const useDownloadQuestionnaire = () => {
   return useMutation({ mutationFn: downloadQuestionnaire });
 };