-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update application analysis CI tests #286
base: main
Are you sure you want to change the base?
Conversation
Updating structure of test-data and adding kantra anlyze tests also for java binary and java with maven settings file. Related to konveyor#233 Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Including also test for https://github.com/konveyor-ecosystem/coolstore @ main branch, quarkus and futher updates will follow. |
Signed-off-by: Marek Aufart <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good, but the result makes me think that there's something wrong with kantra and the tackle-testapp-public app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should name this directory tackle-testapp-public
so that it's easier to find?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there seems to be something wrong with kantra here, because we should be getting one issue related to the local-storage-00001
rule that we're not getting in these results. @rromannissen FYI
<server> | ||
<id>tackle-testapp</id> | ||
<username>konveyor-read-only-bot</username> | ||
<password>GITHUB_TOKEN</password> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At what point do we substitute this token? Is it necessary or this is the actual token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, for source analysis without dependencies, the settings.xml doesn't matter. For full-analysis it need to be replaced, will update.
Updating structure of test-data and adding kantra anlyze tests also for java binary and java with maven settings file.
Related to #233