-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Integrate results view with diff view & add Kai fix webview panel #90
Conversation
@ibolton336 |
1de4589
to
8b8bfc4
Compare
7e968be
to
3cfdf90
Compare
b83b9ce
to
dc7170c
Compare
4e77182
to
e91ce79
Compare
0c3de01
to
54b8a07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK! We can discuss the points in comments later on and if needed fix in follow-up. It would be nice to attach a screencast or screenshots of the the full flow.
Display the resolutionsView panel on solution retrieval Get show resolution panel code working Add new webview routing logic Populate resolutions view from solutions Add more detailed resolution view Add hook for message handler in webview Add hooks and utils for vscode messaging from webview Check if solution uri matches return control to sidebar if resolution page closes Apply file changes from webview and track solution state Signed-off-by: Ian Bolton <[email protected]>
54b8a07
to
52a4621
Compare
Signed-off-by: Ian Bolton <[email protected]>
Screen.Recording.2024-11-19.at.4.15.51.PM.movScreen.Recording.2024-11-19.at.4.38.30.PM.mov |
Add webview messaging for solution request and confirmation for communication between all 3 webviews. New handlers created.
When a solution is requested (getSolution command), the solution is immediately applied.
Logic to handle queue for resolution panel since it is created & messaged at same time during solution request.
The panel needs to exist and have the listener set up before it can receive messages, so needed to implement a queue system. Messages are pushed to the queue if the webview panel isnt ready and then looped through and sent once the panel exists.
Refactor the analysis view card to use PF6 card header & expansion techniques. Allows us the ability to use the dropdown as a part of the card actions. This is where the fix all button currently sits which requests solutions for all incidents within the parent violation umbrella.
Adds a lightbulb icon at the incident level for triggering single incident solution requests.
TODO: