Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add issue tree view #141

Merged
merged 5 commits into from
Dec 11, 2024
Merged

✨ Add issue tree view #141

merged 5 commits into from
Dec 11, 2024

Conversation

rszwajko
Copy link
Contributor

@rszwajko rszwajko commented Dec 9, 2024

Layout:

  1. group incidents by message (top level) and file (2nd level)
  2. within message group the files are sorted based on the entire path
  3. within file group the incidents are sorted based on line number

Actions:

  1. top bar
    1. open Analysis webview
    2. expand all nodes
  2. context:
    1. open details in Analysis webview (currently just opens the webview)
    2. expand all child nodes
  3. one-click expand for nodes with only one child
  4. open Analysis webview when extension is loaded (first time the perspective is accessed)

Refactorings:

  1. move Analysis web view to the editor section (similar to Resolution webview)
  2. disable full screen toggling for Analysis webview
  3. embed initial state data in the HTML to ensure that first message won't be missed

Reference-Url: #140

@rszwajko
Copy link
Contributor Author

rszwajko commented Dec 9, 2024

Screencast.from.2024-12-11.13-26-01.mp4

@rszwajko rszwajko marked this pull request as ready for review December 10, 2024 10:21
@rszwajko rszwajko requested a review from a team as a code owner December 10, 2024 10:21
@rszwajko rszwajko marked this pull request as draft December 11, 2024 09:58
@rszwajko rszwajko marked this pull request as ready for review December 11, 2024 12:44
@rszwajko rszwajko changed the title ✨ Add issue tree view - part 1 ✨ Add issue tree view Dec 11, 2024
ibolton336
ibolton336 previously approved these changes Dec 11, 2024
1. group incidents by message (top level) and file (2nd level)
2. within message group the files are sorted based on the entire path
3. within file group the incidents are sorted based on line number

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko
Copy link
Contributor Author

Force-pushed to resolve conflicts with the latest PR

@rszwajko rszwajko requested a review from ibolton336 December 11, 2024 13:47
@rszwajko rszwajko merged commit a4979b8 into konveyor:main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants