✨ Use immer for extension state #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
changed the title
|
I forget how clean the producers make changing the data look! |
rszwajko
force-pushed
the
liftState
branch
2 times, most recently
from
8178a44
to
b401ee6
Compare
Concentrate data state in the extension object as state.data and enforce top-down propagation of changes. Key points: 1. state is made immutable using Immer - reference comparison can be used to detect changes 2. components interested in receiving notifications about state change should add callbacks via onDidChangeData 3. by convention after initialization the state is modified only via commands Related refactorings: 1. track per-file solution state - LocalChange has now "state" prop with 3 values: pending,applied,discarded 2. use onDidChangeData to trigger file model actions (content of the native Konveyor Resolution view) and in-memory FS actions (suggestion diffs applied to current code) Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
ibolton336
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #103
Concentrate data state in the extension object as state.data and enforce top-down propagation of changes.
Key points:
Related refactorings: