Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 initial collect-assets script #106

Merged
merged 4 commits into from
Nov 22, 2024
Merged

🌱 initial collect-assets script #106

merged 4 commits into from
Nov 22, 2024

Conversation

savitharaghunathan
Copy link
Member

Downloading kai analyzer & server

@savitharaghunathan
initial stab at collect script
a77af13 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan savitharaghunathan requested a review from a team as a code owner November 20, 2024 20:35
@savitharaghunathan savitharaghunathan marked this pull request as draft November 20, 2024 20:36
sjd78
sjd78 reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great base to work from!

For the location of the script (and any future scripts), I'm thinking a scripts/ would be appropriate. Doesn't really matter right now since we can move things around when script 2 is created.

collect-assets.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
collect-assets.js Outdated Show resolved Hide resolved
collect-assets.js Outdated Show resolved Hide resolved
@savitharaghunathan
add review feedback
830eae5 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan savitharaghunathan marked this pull request as ready for review November 21, 2024 19:05
@savitharaghunathan
organize files
76d5168 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan
Copy link
Member Author

For the location of the script (and any future scripts), I'm thinking a scripts/ would be appropriate. Doesn't really matter right now since we can move things around when script 2 is created.

created a scripts/ folder and moved the script into it

sjd78
sjd78 requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more small changes and it'll be good to go.

scripts/collect-assets.js Outdated Show resolved Hide resolved
scripts/collect-assets.js Outdated Show resolved Hide resolved
@savitharaghunathan
address feedback
4ece13e 
Signed-off-by: Savitha Raghunathan <[email protected]>
@sjd78 sjd78 changed the title 🌱 initial stab at collect script 🌱 initial collect-assets script Nov 22, 2024
sjd78
sjd78 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit ae7f628 into konveyor:main Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savitharaghunathan @sjd78