Skip to content

Commit

Permalink
Add feedback from reviews
Browse files Browse the repository at this point in the history
Signed-off-by: Savitha Raghunathan <[email protected]>
  • Loading branch information
savitharaghunathan committed Sep 30, 2024
1 parent f683956 commit 5f0bfac
Showing 1 changed file with 23 additions and 42 deletions.
65 changes: 23 additions & 42 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@ on:
- "main"
- "release-*"

workflow_dispatch:
inputs:
release_branch:
description: 'Branch to release (e.g., main, release-1.0)'
default: 'main'
run_tests:
description: 'Run tests before packaging and releasing (true/false)'
default: 'true'

jobs:
build:
name: Build and Release (${{ matrix.arch }})
Expand All @@ -36,27 +27,10 @@ jobs:
max-parallel: 3

steps:
- name: Check if architecture is selected
id: check_arch
shell: bash
run: |
echo "Selected architectures: ${{ github.event.inputs.architectures }}"
if [[ "${{ github.event.inputs.architectures }}" == *"${{ matrix.arch }}"* ]]; then
echo "should_build=true" >> $GITHUB_OUTPUT
else
echo "should_build=false" >> $GITHUB_OUTPUT
fi
- name: Skip job if architecture not selected
if: ${{ steps.check_arch.outputs.should_build == 'false' }}
run: |
echo "Skipping build for architecture ${{ matrix.arch }}"
exit 0
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ github.event.inputs.release_branch || github.ref }}
ref: ${{ github.ref }}

- name: Set up Node.js
uses: actions/setup-node@v4
Expand All @@ -75,31 +49,26 @@ jobs:
working-directory: ./vscode
run: npm run package

# Install Xvfb on Linux
- name: Install Xvfb (Linux)
if: ${{ runner.os == 'Linux' }}
run: sudo apt-get install -y xvfb

# Run tests on Linux
- name: Run tests (Linux)
if: ${{ github.event.inputs.run_tests == 'true' && runner.os == 'Linux' }}
# Install Xvfb and Run tests on Linux
- name: Install Xvfb and Run tests (Linux)
if: matrix.arch == 'linux'
working-directory: ./vscode
run: xvfb-run npm test
shell: bash
run: |
sudo apt-get install -y xvfb
xvfb-run npm test
# Run tests on macOS
- name: Run tests (macOS)
if: ${{ github.event.inputs.run_tests == 'true' && runner.os == 'macOS' }}
if: matrix.arch == 'macos'
working-directory: ./vscode
run: npm test
shell: bash

# Run tests on Windows
- name: Run tests (Windows)
if: ${{ github.event.inputs.run_tests == 'true' && runner.os == 'Windows' }}
if: matrix.arch == 'windows'
working-directory: ./vscode
run: npm test
shell: cmd
run: npm test

- name: Generate .vsix package
working-directory: ./vscode
Expand All @@ -111,4 +80,16 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: vscode-extension-${{ matrix.arch }}-${{ github.run_id }}
path: "vscode/*.vsix"
path: "vscode/*.vsix"

# Update latest release (only on Linux and for main branch)
- name: Update latest release
if: matrix.arch == 'linux' && github.ref == 'refs/heads/main'
uses: marvinpinto/action-automatic-releases@latest
with:
repo_token: "${{ secrets.GITHUB_TOKEN }}"
automatic_release_tag: "latest"
prerelease: true
title: "Development Build"
files: |
vscode/*.vsix

0 comments on commit 5f0bfac

Please sign in to comment.