Warn if local clock and host clock are out of sync #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakolehm
reviewed
Aug 29, 2019
jakolehm
reviewed
Sep 2, 2019
There was a problem hiding this comment.
Still seeing this in the output:
[default-master-0] Retrying after 2 seconds (#33) ...
[default-master-0] SSL_connect returned=1 errno=0 state=error: certificate verify failed (certificate is not yet valid) (OpenSSL::SSL::SSLError) Unable to verify certificate. This may be an issue with the remote host or with Excon. Excon has certificates bundled, but these can be customized:
[default-master-0]
[default-master-0] `Excon.defaults[:ssl_ca_path] = path_to_certs`
[default-master-0] `ENV['SSL_CERT_DIR'] = path_to_certs`
[default-master-0] `Excon.defaults[:ssl_ca_file] = path_to_file`
[default-master-0] `ENV['SSL_CERT_FILE'] = path_to_file`
[default-master-0] `Excon.defaults[:ssl_verify_callback] = callback`
[default-master-0] (see OpenSSL::SSL::SSLContext#verify_callback)
[default-master-0] or:
[default-master-0] `Excon.defaults[:ssl_verify_peer] = false` (less secure).
Can we format it better (without excon stuff)?
|
Now it should only display |
…luster into feature/clock_sync_warn
jakolehm
reviewed
Sep 2, 2019
| @@ -17,7 +17,11 @@ def self.format_exception(exc, severity = "ERROR") | |||
| backtrace = "\n #{exc.backtrace.join("\n ")}" | |||
| end | |||
|
|
|||
| "Error: #{exc.message.strip}#{backtrace}" | |||
| if exc.is_a?(Excon::Errors::CertificateError) | |||
| "Error: #{exc.message.lines.first[/(.+?\))/, 1]}#{backtrace}" | |||
There was a problem hiding this comment.
Is this really safe? Does excon always have (something) in place that we can use for search?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows a warning if localhost and host clocks are more than 60 seconds apart.