Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generics, forward references and case conversion #269

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

avlonder
Copy link

No description provided.

@avlonder
Copy link
Author

On my side, the last benchmark is highlighted in red. Is this a problem?

@mciszczon
Copy link
Collaborator

mciszczon commented Jan 14, 2025

On my side, the last benchmark is highlighted in red. Is this a problem?

Sometimes we might want to trade a small performance hit for highly enhanced functionality, right? But some of the tests still fail, some due to the usage of newer Python functionalities in Python 3.7 and 3.8 environments, some seem to be legit issues with the code.

You can try to run tests on different Python versions locally, and I'll try to also look into it in the upcoming days. Sorry for that, a bit busy right now. But definitely let's push this forward so we can finally merge it into the repo.

@konradhalas What do you think about the change_keys part? I do agree it's a bit out of scope of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants