-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PEP 604 unions, types.UnionType #184
Support PEP 604 unions, types.UnionType #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After patching some other APIs to work with PEP 604 union types, this fix looks correct to me.
Hi @konradhalas, Thanks @antonagestam If only I spent a few minutes to check if that was already fixed before spending the time to fix it myself :( ... |
Hi @konradhalas, I too stumbled upon this and spent a lot of time trying to fix things. |
I would also love to see a new version of dacite including this fix. dacite is currently keeping us from consistently using shorthand-typehints for optional attrs in dataclasses :-( |
Hello, is this pull request still active? Just encountered an issue because of the issue mentioned. |
@antonagestam thank you very much for your PR - good job! I'm sorry you had to wait so long. |
@konradhalas No worries, thank you for merging this. OSS is free work and I have a lot of respect for the time it takes from people's lives. So, thanks again! 🙏 |
Fixes #180
This is essentially the same fix as this one: ilevkivskyi/typing_inspect#83