-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Go managers #98
base: main
Are you sure you want to change the base?
Conversation
config/renovate/renovate.json
Outdated
}, | ||
"additionalBranchPrefix": "{{baseBranch}}/", | ||
"branchPrefix": "konflux/mintmaker/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change have an effect on tekton manager branches?
Perhaps it's just github diff changes that is a bit chaotic. But it seems like |
I'd suggest splitting the We should test the go manager more carefully as this manager is a little complicated and users opened several requests regarding this manager (though they were opened against the other internal renovate instance). |
"additionalBranchPrefix": "", because of this error:
|
Btw I think it's fine to keep all changes in this PR, but it really helps in this case to change GitHub's diff view to "split" (= side by side). |
d94540f
to
05291d5
Compare
Thank you for the review, i split the change into 2 PRs, rebased and added schedules as well. can you take another look please? |
I tested
and all worked, but it needs the following config to work for all cases: "gomod":
{
"postUpdateOptions":
[
"gomodUpdateImportPaths",
"gomodTidy"
]
},
"packageRules":
[
{
"matchManagers":
[
"gomod"
],
"matchDepTypes":
[
"indirect"
],
"enabled": true
}
] |
e153c59
to
013618d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests passed, I think we can merge it if others agree.
Converted to draft until optimizations are in place so we dont exceed renovate's runtime. |
2 Go managers are added in this commit. I also moved the
branchPrefix
attribute one level higher as it seems from the documentation the effect stays the same.Closes CWFHEALTH-3173
Related PR: konflux-ci/mintmaker-renovate-image#71