Skip to content

Commit

Permalink
Dockerfile: use bats-core
Browse files Browse the repository at this point in the history
The bats testing framework we use for integration test is not maintained
since 2015 and was superceded by bats-core [1]. Unfortunately, Debian
still packages very old version of bats from the old repo.

Use recent bats-core as installed by npm, as recommended in [3].

[1] sstephenson/bats#269
[3] https://github.com/bats-core/bats-core/wiki/Install-Bats-Using-a-Package

Signed-off-by: Kir Kolyshkin <[email protected]>
  • Loading branch information
kolyshkin committed Apr 11, 2020
1 parent ccbb336 commit 8c78269
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ARG GO_VERSION=1.13
ARG BATS_VERSION=03608115df2071fff4eaaff1605768c275e5f81f
ARG CRIU_VERSION=v3.13

FROM golang:${GO_VERSION}-buster
Expand Down Expand Up @@ -33,6 +32,7 @@ RUN dpkg --add-architecture armel \
libseccomp-dev:armhf \
libseccomp-dev:ppc64el \
libseccomp2 \
npm \
pkg-config \
protobuf-c-compiler \
protobuf-compiler \
Expand All @@ -49,13 +49,7 @@ RUN dpkg --add-architecture armel \
RUN useradd -u1000 -m -d/home/rootless -s/bin/bash rootless

# install bats
ARG BATS_VERSION
RUN cd /tmp \
&& git clone https://github.com/sstephenson/bats.git \
&& cd bats \
&& git reset --hard "${BATS_VERSION}" \
&& ./install.sh /usr/local \
&& rm -rf /tmp/bats
RUN npm install -g bats

# install criu
ARG CRIU_VERSION
Expand Down

0 comments on commit 8c78269

Please sign in to comment.