Skip to content

Commit

Permalink
Dockerfile: use bats-core
Browse files Browse the repository at this point in the history
The bats testing framework we use for integration test is not maintained
since 2015 and was superceded by bats-core [1]. More to say, we were
using an unreleased version and relying on some features of it
(unfortunately I don't remember now what are those features exactly).

As Debian still packages very old version of bats from the old repo,
so let's Use recent bats-core from the new, supposedly better maintained,
github repo.

[1] sstephenson/bats#269

Signed-off-by: Kir Kolyshkin <[email protected]>
  • Loading branch information
kolyshkin committed Apr 21, 2020
1 parent 5b38ef7 commit 109482f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG GO_VERSION=1.13
ARG BATS_VERSION=03608115df2071fff4eaaff1605768c275e5f81f
ARG BATS_VERSION=v1.1.0
ARG CRIU_VERSION=v3.13

FROM golang:${GO_VERSION}-buster
Expand Down Expand Up @@ -51,11 +51,11 @@ RUN useradd -u1000 -m -d/home/rootless -s/bin/bash rootless
# install bats
ARG BATS_VERSION
RUN cd /tmp \
&& git clone https://github.com/sstephenson/bats.git \
&& cd bats \
&& git clone https://github.com/bats-core/bats-core.git \
&& cd bats-core \
&& git reset --hard "${BATS_VERSION}" \
&& ./install.sh /usr/local \
&& rm -rf /tmp/bats
&& rm -rf /tmp/bats-core

# install criu
ARG CRIU_VERSION
Expand Down

0 comments on commit 109482f

Please sign in to comment.