Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: set Kokkos version to 4.4.01 #60

Merged
merged 1 commit into from
Sep 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/Modules/KokkosPythonOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ set(CMAKE_C_VISIBILITY_PRESET "default" CACHE STRING "Default visibility")
set(CMAKE_CXX_VISIBILITY_PRESET "default" CACHE STRING "Default visibility")

# pybind11 has not migrated to CMAKE_CXX_STANDARD and neither has kokkos
SET(CMAKE_CXX_STANDARD 14 CACHE STRING "C++ language standard")
SET(CMAKE_CXX_STANDARD 17 CACHE STRING "C++ language standard")
SET(CMAKE_CXX_STANDARD_REQUIRED ON CACHE BOOL "Require standard")
SET(CMAKE_CXX_EXTENSIONS OFF CACHE BOOL "Extensions")
IF(NOT Kokkos_CXX_STANDARD)
Expand Down
2 changes: 1 addition & 1 deletion external/kokkos
Submodule kokkos updated 1430 files
1 change: 1 addition & 0 deletions include/pools.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@

#include <Kokkos_Core.hpp>
#include <Kokkos_Random.hpp>
#include <iostream>

namespace Common {
template <typename PoolT, typename Sp>
Expand Down
1 change: 1 addition & 0 deletions include/views.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@

#include <Kokkos_Core.hpp>
#include <Kokkos_DynRankView.hpp>
#include <iostream>

//----------------------------------------------------------------------------//

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def add_arg_bool_option(lc_name, disp_name, default=None):
add_arg_bool_option("timing", "ENABLE_TIMING")
parser.add_argument(
"--cxx-standard",
default=14,
default=17,
type=int,
choices=[14, 17, 20],
help="Set C++ language standard",
Expand Down
1 change: 1 addition & 0 deletions src/enumeration.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
#include <pybind11/pytypes.h>

#include <cassert>
#include <iostream>

//----------------------------------------------------------------------------//

Expand Down
1 change: 1 addition & 0 deletions src/libpykokkos.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
#include "traits.hpp"

#include <Kokkos_Core.hpp>
#include <iostream>

//----------------------------------------------------------------------------//
//
Expand Down
Loading