-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parenthesis position in submdspan #368
Conversation
Btw, we have two ways to check if we have to workaround CTAD issues
Could we keep only one ? |
I would go for the safer solution 1. mdspan/include/experimental/__p2630_bits/submdspan_mapping.hpp Lines 560 to 563 in 771e3ca
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah Number one is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be done in a follow up unifying the guard.
Closes #367