unstdify config.hpp macros #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmm0
commented
Nov 26, 2024
| @@ -15,21 +15,25 @@ | |||
| //@HEADER | |||
| #pragma once | |||
|
|
|||
| #ifndef __has_include | |||
| # define __has_include(x) 0 | |||
| #ifndef MDSPAN_IMPL_HAS_INCLUDE | |||
There was a problem hiding this comment.
I switched this to our own macro rather than substituting in the standard one (since I think that could propagate a bug downstream if someone does #ifdef __has_include
There was a problem hiding this comment.
This is much better; thank you! : - )
nmm0
commented
Nov 26, 2024
| # endif | ||
| #endif | ||
|
|
||
| #ifndef __has_cpp_attribute | ||
| # define __has_cpp_attribute(x) 0 | ||
| #ifndef MDSPAN_IMPL_HAS_CPP_ATTRIBUTE |
dalg24
reviewed
Nov 27, 2024
mhoemmen
approved these changes
Nov 29, 2024
@dalg24 ok, I can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the bugprone-reserved-identifier clang-tidy check to find these, and a global search/replace to fix them. I kept these changes isolated to ones declared in config.hpp and plan on doing more later. (As you can see, even just the config.hpp ones touch basically every file)