Adopt Kokkos::StaticCrsGraph from "Core" and move Static{Ccs,Crs}Graph to namespace KokkosSparse::
#2419
Conversation
* Moved Static{Ccs,Crs}Graph to namespace KokkosSparse and into their
own new header files
* Deprecate symbols in Kokkos namespace
* CRS counterpart used to come from the Containers subpackage in Kokkos
"Core" but now is transitioned to Kokkos Kernels.
Signed-off-by: Damien L-G <[email protected]>
Signed-off-by: Damien L-G <[email protected]>
| using Kokkos::create_staticcrsgraph; | ||
| using Kokkos::GraphRowViewConst; | ||
| using Kokkos::maximum_entry; | ||
| using Kokkos::StaticCrsGraph; |
There was a problem hiding this comment.
I am not sure what to do about create_mirror[_view]
I certainly want to pull all overloads from Kokkos into KokkosSparse::
There was a problem hiding this comment.
I don't think Kokkos provides create_mirror... functions for any other non-view containers, right? Shall we just be consistent with that and move them into KokkosSparse namespace? Kokkos can make the suggestion in the deprecation message.
|
|
||
| } /* namespace TestStaticCrsGraph */ | ||
|
|
||
| TEST(NotSureWhatGoesThere, staticcrsgraph) { |
There was a problem hiding this comment.
Need to fix this before we merge
Let me know how you would like to call it
There was a problem hiding this comment.
We just put TestCategory and it gets set in e.g. test_common/Test_HIP.hpp for different backends.
There was a problem hiding this comment.
Looks like this still needs to be addressed, adding Carl's advice as a code suggestion:
| TEST(NotSureWhatGoesThere, staticcrsgraph) { | |
| TEST(TestCategory, staticcrsgraph) { |
…to static_crs_graph
|
kokkos-kernels nightly builds with deprecated code off are failing after merge of kokkos/kokkos#7516 , I'm assuming merge of this PR is needed to get develop branches back in sync? For reference, this is the error: |
|
The issues with runners should be resolved (killed some of the previous runs) |
This PR implements what we agreed on, that is Kokkos "Core" is deprecating
Kokkos::StaticCrsGraphand we transition it to Kokkos Kernels intoKokkosSparse::.On 2nd thought we decided to give up on raising deprecation warnings because it was too tricky to guarantee same symbols and not emit diagnostics when the KokkosSparse:: versions are used.