Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batched - dense: Testing and fixing Serial QR #2342

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

batched - dense: Testing and fixing Serial QR #2342

wants to merge 16 commits into from

Commits on Nov 6, 2024

  1. batched - dense: Testing and fixing Serial QR 

    The serial QR algorithms does not have unit-tests and is failing
for non square matrices. See issue kokkos#2328.
This first commit fixes the issue with rectangular matrices and
adds a basic test for that use case. Next will work on adding a
test that exercises the interfaces on multiple matrices of different
sizes within a parallel_for. Finally equivalent tests will be added
for the square case as well.

Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    cb597ce View commit details
    Browse the repository at this point in the history

  2. Actually commiting the new the new tests... 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e806706 View commit details
    Browse the repository at this point in the history

  3. Fixing unused variable error 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6e4330e View commit details
    Browse the repository at this point in the history

  4. Batch - QR: starting test process for FormQ 

    It looks like the Left NoTranspose ApplyQ is not doing the correct
thing. Will have a look at that next.

Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8cbc1aa View commit details
    Browse the repository at this point in the history

  5. Batched - QR: adding tests for batch of variable size matrices 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1283473 View commit details
    Browse the repository at this point in the history

  6. Batched - QR: clang-format and cast values in macro 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    90a1deb View commit details
    Browse the repository at this point in the history

  7. Batch - QR: fixing obvious type... 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7c17049 View commit details
    Browse the repository at this point in the history

  8. Batch - QR: simplifying batch QR test. 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7d21889 View commit details
    Browse the repository at this point in the history

  9. Batched - QR: fix execution space in unit-test views 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b8dadce View commit details
    Browse the repository at this point in the history

  10. Batched - QR: applying clang-format 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0a4ba79 View commit details
    Browse the repository at this point in the history

  11. Batch - QR: fixing type issue in macro 

    Signed-off-by: Luc <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    748bfc8 View commit details
    Browse the repository at this point in the history

  12. Batch - QR: finishing batched unit-test 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    82796eb View commit details
    Browse the repository at this point in the history

  13. Applying clang-format 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f7e5877 View commit details
    Browse the repository at this point in the history

  14. Batched - QR: some debugging...

    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fb6fc4d View commit details
    Browse the repository at this point in the history

  15. Printing more debug outputs

    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c1162a7 View commit details
    Browse the repository at this point in the history

  16. Fixing an issue with transpose in SerialQR unit-test

    @lucbv
    lucbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b24686b View commit details
    Browse the repository at this point in the history