Skip to content

Commit

Permalink
refactor(build): remove VCRedist msm
Browse files Browse the repository at this point in the history
Introduced in 7f4392b.
  • Loading branch information
ilharp committed Jul 7, 2023
1 parent 561be92 commit b3fb7da
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 29 deletions.
1 change: 0 additions & 1 deletion config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const versionNode = '16.19.1'
export const versionYarn = '3.5.0'

export const versionWebView2 = '1.0.1343.22'
export const versionMSVC = '14.34.31931'
export const versionAppimagetool = '13'

export const versionToolsVersioninfo = 'v1.4.0'
Expand Down
11 changes: 0 additions & 11 deletions packages/build/tasks/pack/unfold.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import { series } from 'gulp'
import mkdirp from 'mkdirp'
import fs from 'node:fs/promises'
import { join } from 'node:path'
import { sleep } from '../../utils/common'
import { zip } from '../../utils/compress'
import { versionMSVC } from '../../utils/config'
import { dir } from '../../utils/path'
import { exec } from '../../utils/spawn'

Expand Down Expand Up @@ -43,15 +41,6 @@ export const packUnfoldDataCopy = async () => {
dir('buildCache', 'Webview2Setup.exe'),
dir('buildUnfoldBinary', 'Webview2Setup.exe')
)

// Copy VCRedist
await fs.copyFile(
join(
process.env['PROGRAMFILES']!,
`Microsoft Visual Studio/2022/Enterprise/VC/Redist/MSVC/${versionMSVC}/MergeModules/Microsoft_VC143_CRT_x64.msm`
),
dir('buildUnfoldBinary', 'Microsoft_VC143_CRT_x64.msm')
)
}
}

Expand Down
17 changes: 0 additions & 17 deletions packages/build/templates/msi/index.wxs.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@
/>
</Component>

<Merge
Id="ComponentVCRedist"
SourceFile="SourceDir\Microsoft_VC143_CRT_x64.msm"
Language="0"
/>

<Directory Id="DirectoryInstallBinary" Name="bin">
<Component
Id="ComponentDirectoryInstallBinary"
Expand Down Expand Up @@ -231,17 +225,6 @@
<ComponentRef Id="ComponentDirectoryProgramMenuFolder" />
</Feature>

<Feature
Id="FeatureVCRedist"
Title="Visual C++ Runtime"
Description="Visual C++ runtime. Required for Koishi Desktop Shell."
Level="1000"
InstallDefault="local"
AllowAdvertise="no"
>
<MergeRef Id="ComponentVCRedist" />
</Feature>

<Feature
Id="FeatureDesktopIcon"
Title="Desktop Icon"
Expand Down

0 comments on commit b3fb7da

Please sign in to comment.