Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docker/dind to 24.0.6 to fix CI #911

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Pin docker/dind to 24.0.6 to fix CI #911

merged 2 commits into from
Dec 15, 2023

Conversation

jamesrkiger
Copy link
Contributor

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Fixes an issue with Docker images that cause GitLab CI to fail on the 'build' step.

Notes

Same fix for docker image as we made here for KPI.

@jamesrkiger jamesrkiger changed the base branch from main to beta December 15, 2023 17:46
@jamesrkiger jamesrkiger requested a review from LMNTL December 15, 2023 17:56
Copy link
Contributor

@LMNTL LMNTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! One request before I merge: would you mind adding a comment like this above the image: docker line? You can copy-paste it or write your own, I just want to make sure that the next person who has to modify this file knows to revert this change when the issue's resolved.

@jamesrkiger jamesrkiger merged commit 6558aed into beta Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants