Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change path -to-regexp to 6.3.0 #76

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Change path -to-regexp to 6.3.0 #76

wants to merge 5 commits into from
+39 −12

Conversation

dudek824
Copy link

@dudek824 dudek824 commented Oct 2, 2024

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Sorry, something went wrong.

@dudek824 dudek824 marked this pull request as ready for review October 2, 2024 19:45
@dudek824
Copy link
Author

dudek824 commented Oct 2, 2024

Please help review change

@rnwalker7
Copy link

This change is to mitigate CVE-2024-45296.

@rnwalker7
Copy link

@jonathanong Mind taking a look at this?

jonathanong
jonathanong reviewed Mar 19, 2025
View reviewed changes
package.json
@@ -23,8 +23,9 @@
"license": "MIT",
"dependencies": {
"debug": "*",
"koa-route": "^4.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it adding itself as a dependency?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Missed that during my review. I'll go in and remove that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I cannot go in and change it. @dudek824, please remove the self-reference from package.json. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanong jonathanong

@rnwalker7 rnwalker7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dudek824 @rnwalker7 @jonathanong