Ascendex cancel order fix #4745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walec51
requested changes
Aug 13, 2023
| @@ -32,6 +31,20 @@ public String placeLimitOrder(LimitOrder limitOrder) throws IOException { | |||
|
|
|||
| @Override | |||
| public boolean cancelOrder(CancelOrderParams orderParams) throws IOException { | |||
| if (orderParams instanceof DefaultCancelOrderByInstrumentAndIdParams) { | |||
There was a problem hiding this comment.
you should type check by interface not their default implementation
please do orderParams instance of CancelOrderByIdParams && orderParams instanceof CancelOrderByInstrument
if both are needed
if only one is needed then use ||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of cancelOrder method for Ascendex trade service does not work correctly. It removes all orders based on currency pair and ignores the orderId.
Current version of cancelOrder is renamed to cancelAllOrdersByCurrencyPair and the cancelOrder method has been changed to remove only the order with the given id.
cancelOrder method's functionality is now inline with other trade services' method with the same name.