Coding challenge 0.1 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviadP
reviewed
Nov 29, 2019
| @@ -0,0 +1,21 @@ | |||
|
|
|||
| def most_common_word(file_name): | |||
There was a problem hiding this comment.
+1 for using functions
but, best practice, is to create few functions, with each one of them doing 1 thing only
|
|
||
|
|
||
| if __name__== "__main__": | ||
| file_name = input("insert file path: ") |
There was a problem hiding this comment.
it is a bit risky to ask user to enter file name, if your decision is to do so, you man want to use some validation for his input
| file_name = input("insert file path: ") | ||
| most_common_word(file_name) | ||
|
|
||
|
|
There was a problem hiding this comment.
please make sure you code pass Flask8 lint validation
|
Hi @AviadP |
AviadP
approved these changes
Dec 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding my solution for challenge